Fix JavaScript screenshot coverage for shared UI changes - #5361
Merged
Conversation
Contributor
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
Collaborator
Author
|
Compared 135 screenshots: 135 matched. |
shai-almog
added a commit
that referenced
this pull request
Jul 11, 2026
…ty-suite Conflicts resolved by keeping the branch side: - scripts/cn1playground/pom.xml: keep the deliberate 8.0-SNAPSHOT pin (master's 7.0.258 release bump must not touch the playground pin). - 14 scripts/javascript goldens: master's #5361 regenerated them on a tree without this branch's theme changes; ours were captured from the merged tree post-#5358 and remain correct for this PR. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TextAreavertical-alignment correctionCodenameOne/src/**runtime files changeRoot cause
Commit
78eb3a7148changed sharedTextArearendering and refreshed the iOS/macOS goldens, but the JavaScript workflow did not run because its path filters omittedCodenameOne/src/**. A later HelloCodenameOne change triggered the workflow and exposed the 15 stale JavaScript references on master.Impact
The JavaScript screenshot suite now accepts the intentional rendering change, and future shared runtime/UI changes will exercise the JavaScript screenshot gate on both pull requests and master pushes.
Validation
.github/workflows/scripts-javascript.ymlsuccessfully with Ruby YAMLgit diff --check